PNG badge urls are returning a 404

h4cc / hhvm-progress

Source of the hhvm.h4cc.de website.

http://hhvm.h4cc.de/

MIT License

8 stars 4 forks source link

PNG badge urls are returning a 404 #53

Closed stof closed 9 years ago

stof commented 9 years ago

This is breaking badges in readmes of all projects using the badges, which is a bad idea. Providing a SVG badge is good, but existing URLs should remain functional

h4cc commented 9 years ago

Which package badge does return 404?

The PNG feature itself is still working: http://hhvm.h4cc.de/badge/symfony/symfony.png

stof commented 9 years ago

http://hhvm.h4cc.de/badge/behat/behat.png?branch=master is a 404

stof commented 9 years ago

hmm, looks like the issue is actually that the handling of branch names changed by expecting a composer version rather than a branch name

h4cc commented 9 years ago

Ah, i see. This URL works: http://hhvm.h4cc.de/badge/behat/behat.png?branch=dev-master

I will try to accept both or fix it as far as possible.

h4cc commented 9 years ago

Badges work now. Thank you very much for your contribution! :+1: