search

h4de5 / home-assistant-toshiba_ac

Toshiba AC integration into home-assistant.io
GNU General Public License v3.0
113 stars 17 forks source link

added a fix for Home Assistant 2024.1.0 #163

Closed PatrikTheDev closed 6 months ago

PatrikTheDev commented 6 months ago

One of the calls to ToshibaAcEnumSelectDescription.__init__() in _SELECT_DESCRIPTIONS was missing an icon_mapping parameter which started causing issues on Home Assistant 2024.1.0. I've added the missing parameter which has fixed the issue. Another option would have been to mark the field as optional but this was a simpler change (I'm not an experienced Python dev, most of my work is in TypeScript).

I've tested this change on my local instance and it fixes the issue.

h4de5 commented 6 months ago

thank you very much for you contribution!

dominicusmento commented 5 months ago

@h4de5 Can this be published?

h4de5 commented 5 months ago

donev https://github.com/h4de5/home-assistant-toshiba_ac/commit/86f9dbaa0dd6adb49da0b0fd76289259002445f2

sorry about that.