h4de5 / home-assistant-toshiba_ac

Toshiba AC integration into home-assistant.io
GNU General Public License v3.0
127 stars 18 forks source link

hvac_action removed? #95

Closed SketchCND closed 1 year ago

SketchCND commented 1 year ago

Upgraded to 2022.11.0 and hvac_action attribute is missing.

Is there a particular reason for this that I may have missed or is it meant to be removed from current release? I was making use of the attribut in my HA instance and hence have noticed it missing

tetienne commented 1 year ago

Hi,

This information was removed few releases ago.

Indeed, the information was not accurate and was just based on comparing the current temperature with the target temperature which is not enough and not allowed by Home Assistant Core team.

The information must be returned by the device itself and not compute.

SketchCND commented 1 year ago

@tetienne - thank you for the information as to why it was removed - it makes sense.

"This information was removed few releases ago." Not quite accurate as far as I can make out. Until upgrading to 2022.11.0, I was running at the time the current release of 2022.7.1 which was the release prior 2022.11.0 and the hvac_action attribute was available and indeed I can see it being calculated in the climate.py source code of that release.

As I now understand that it will no longer be usable, I'll re-evaluate my HA strategy to account for this change.