h4de5 / home-assistant-vimar

VIMAR by-me integration into home-assistant.io
GNU General Public License v3.0
42 stars 6 forks source link

Patch Sensors, particularly power and energy sensors to work with statistics. And patch climate controls #44

Closed robigan closed 1 year ago

kubaceg commented 2 years ago

What's the status? Can I help develop/test it?

robigan commented 2 years ago

What's the status? Can I help develop/test it?

Dead, summer holidays started for me, so I may get back to patching and improving. I also want to see how different the new by web servers differ from the ones this repo support, but I don't own any hardware to test, so...

robigan commented 2 years ago

@h4de5 Can u verify this pr?

h4de5 commented 2 years ago

@robigan I am aware of it - there is a working branch with many more changes here: https://github.com/h4de5/home-assistant-vimar/tree/room_integrations

i need to check first if this would conflict.

robigan commented 2 years ago

@robigan I am aware of it - there is a working branch with many more changes here: https://github.com/h4de5/home-assistant-vimar/tree/room_integrations

i need to check first if this would conflict.

Just tried merging this PR into rooms_integrations, should be all smooth apart from the 3 conflicting files. For .gitingore you can implement my change (current change), for climate.py, implement the incoming change but do set the function mode to VIMAR_CLIMATE_MANUAL because otherwise you won't be able to set temp in auto mode. And manifest.json is to just bump the version

robigan commented 2 years ago

Opened a new PR if you just want to quickly merge with what I said

h4de5 commented 1 year ago

after checking again, this is already included in #48