h4de5 / home-assistant-vimar

VIMAR by-me integration into home-assistant.io
GNU General Public License v3.0
42 stars 6 forks source link

Not all HVACs support all hvac modes #66

Open robigan opened 11 months ago

robigan commented 11 months ago

Was taking a look at the code for climate systems and I noticed that the code returns auto, heat, cool, and off modes as supported in all climate modes, this is not true.

Here is an image of this:

image

I can work on a simple patch ready within the next 2 hours if all goes smooth, just gotta figure out what properties are which if I can even remember how to do it 😅

robigan commented 11 months ago
image

Left has only heating, right has heating and cooling

Possibly this is it? Any RFCs?

robigan commented 11 months ago

Just compared the right of my previous image with another room that has only heating and I got this:

image
robigan commented 11 months ago

Yeah same results on two other rooms Left is the kitchen with heating and cooling, right is another random room with only heating

image
h4de5 commented 11 months ago

sorry, i must have missed this yesterday.

there are very different climate devices from vimar out there. they do offer different features and unfortunately even have different states and options, making a consolidated interface really hard to implement. there are still some bugs related to this mess open (e.g. #19) and i do have a hard time fixing them because i only have access to one type and I do not want to break it for others. I was thinking about restructuring climate.py to get a better idea of the different types but i do not find enough time to do this.

robigan commented 11 months ago

I was hoping to finish the patches yesterday but due to my schedule and problems with setting up dev env I am gonna have to try and finish this tomorrow. Maybe it's time I skirted the law and possibly decompiled the firmware to understand it's inner workings? Either way I am gonna make my own patches, maybe it's possible to implement something that'll raise awareness towards helping figure out various setups such as an alert in Home Assistant?