search

h4kuna / fio

Read and send payment order for FIO bank, PSR-17 ready
54 stars 25 forks source link

Queue::createXmlResponse calls getBody on Stream #31

Closed Tetragramat closed 5 years ago

Tetragramat commented 5 years ago

Sending payments is now broken.

In Queue.php line 187:

  [Symfony\Component\Debug\Exception\UndefinedMethodException]                              
  Attempted to call an undefined method named "getBody" of class "GuzzleHttp\Psr7\Stream".

Method Queue::createXmlResponse contains invalid typehint. Instead ResponseInterface|GuzzleHttp\Psr7\Stream should be ResponseInterface.

On the line src/Request/Queue.php:91 is Queue::createXmlResponse called with wrong argument.

It was broken by lastest commit

h4kuna commented 5 years ago

Thank you for report, could you try this fix in this branch fix-invalid-typehint?

I try on my fio account by this script and looks fine.

Tetragramat commented 5 years ago

I'm unable to test it. There should be unit tests for that.

h4kuna commented 5 years ago

You have right. In this moment for this use case, tests does not exists. Could you send PR?

h4kuna commented 5 years ago

Merge to master and releas new version