fix: remove custom icon handler for outfits

h4lfheart / FortnitePorting

Automation of the Fortnite Porting Process

GNU General Public License v3.0

250 stars 45 forks source link

fix: remove custom icon handler for outfits #72

Closed va1729 closed 2 months ago

va1729 commented 2 months ago

I believe none of the outfits have a SmallPreviewImage and LargePreviewImage anymore. We are able to get the icons from the default IconHandler itself. so removed it.

CID_Bean also doesn't have any icon or anything. So added it to DisAllowNames although I am not sure what a 'Bean' outfit is.

h4lfheart commented 2 months ago

small preview image and large preview image are left there for backwards compatibility in older versions of fortnite

va1729 commented 2 months ago

Hmm. it does result in some wrong/missing images like for example - Character_CattleJar - Meowtooth with the latest version. I think at least the order of accessing should be changed.

If it first accesses the one from hero definition, the icon is T_Placeholder_Item_Outfit-S whereas the actual icon is T_Soldier_CattleJar. Similar issue with Nix Scarlet and few others.