Closed probablykasper closed 2 years ago
ok, thanks I'll roll it back
I just yanked that version, could you help me out with a reproducer?
TIL: don't hastily revert code when you actually wanted to go to bed. This took two attempts 😆 , 0.5.4 didn't actually build so instead of applying git magic at the late hour I added another tag.
so 0.5.3
was yanked, 0.5.4
was doa and 0.5.5
is the new retro release that looks just like 0.5.2
, just newer
I was actually not able to reproduce this yet, so I'd be really grateful for a reproducer @probablykasper. also maybe @BlackHoleFox has an idea what might be happening here?
thanks already for the feedback!
Ah, it might be only when notifications are created within a tokio runtime.
This is the Tauri app where this happened in: https://github.com/probablykasper/remind-me-again
In case you're familiar with Tauri, I was able to reproduce it just by having a Tauri command that shows a notification
On macOS a lot of things need to happen on the main thread. Doing this on a background threads, as is likely in a tokio runtime, could be the cause of this.
thanks @thomcc! do you think we might still get some of the ARC benefits of @BlackHoleFox 's original change?
I don't think that any of my changes are inherently compatible with threads on the surface, but the one good thing is to see if it was the ARC changes or the NSWorkspace changes. Ill throw my branch up again and experiment if no one beats me to it.
@probablykasper can I bug you to copy/paste the macOS crash report here on GitHub with any redactions you think are necessary? (If you can't crash it freshly, check Console.app
--> Crash Reports
).
I built your app locally with it pointed at a local checkout of mac-notification-sys
with all my changes but I can't seem to reproduce on macOS 12.4.
I actually ended up pinning mac-notigication-sys
to 0.5.2 in https://github.com/probablykasper/remind-me-again/commit/952c6e73ca080e47861b347b93b5941d51aa0939 so that might be why, sorry. The commit https://github.com/probablykasper/remind-me-again/commit/bca112feddefe7c899d92487031d3e5c60a95c0f has the issue.
Here's a crash log from it:
I'm using Tauri's notification API, which depends on
mac-notification-sys
. It seems like v0.5.3 introduced a bug that terminates the app once 2 notifications are shown.Pinning
mac-notification-sys
to0.5.2
fixed this for me, so seems like an issue withv0.5.3
.OS: macOS 10.15