search

h4zm1 / Cyberpunk-Theme

Dark "Cyberpunk" theme for visual studio 19/22
https://marketplace.visualstudio.com/items?itemName=T0uchM3.CTVS19
MIT License
51 stars 7 forks source link

Low readability of inline hints #14

Closed pyrocumulus closed 1 year ago

pyrocumulus commented 1 year ago

Problem I've been using this theme for quite a bit and I'm really liking it thus-far. I love the contrast it provides. However, there is one small area in which that contrast is lacking, and that's regarding inline hints: image I don't usually use the hint for the inferred variable types (var keyword), but I do use them for the hints on lambda parameters. This was to further highlight the problem that users could face.

Depending on the type that is referred to in the inline hint, the readability of the hint can become incredibly low. As you can see string in this case is 'okay' to read but the SocketSlashCommandDataOptions really requires squinting before you can see what's going on.

Suggested solution As for fixing this I think tweaking the light gray 'marking' colour would be best. I think a bit darker gray would be all that's needed.

Additional information If you are unaware of how you can get those inline hints, they are in the C# Text editor options, under Advanced (scroll all the way down). image

Mandatory environment information:

Visual Studio Community / Professional Edition Version 17.5.3
Cyberpunk Theme Version 2.2
Microsoft Windows 11 Pro Version    10.0.22621 Build 22621
pyrocumulus commented 1 year ago

I found another similar issue, but not with text.

On my professional machine, running Windows 10, there appears to be no clear window border for the Quickwatch window: image Perhaps other tool windows have the same issue.

Exact version of Windows this happens on:

OS Name Microsoft Windows 10 Enterprise
Version 10.0.19045 Build 19045

On my personal Windows 11 system I do get a border: image I think it's because of the new W11 styling, the corners of the window are rounded as well.

I don't know if it's possible to fix this but it would be most helpful :)

h4zm1 commented 1 year ago

Thanks for reporting this, will look into it, may take a while tho (irl stuff). Good description btw ;)

pyrocumulus commented 1 year ago

No problem! I know most end users of open-source things never bother to give feedback. I want to be one that does, but there's really no hurry. Real life always takes priority over open source :)

h4zm1 commented 1 year ago

Will investigate the second problem soon.