h5bp / Effeckt.css

This repo is archived. Thanks!
http://h5bp.github.io/Effeckt.css
MIT License
10.88k stars 1.4k forks source link

bug: wrong class name & loss of 3d-ness-perspective #274

Closed wonglok closed 10 years ago

wonglok commented 10 years ago

Wrong Class name for offscreen nav. there is no md-perspective class name in scss / css source. is md-perspective referring to effeckt-perspective?

Ref: https://github.com/h5bp/Effeckt.css/search?q=md-perspective&type=Code https://github.com/h5bp/Effeckt.css/search?q=effeckt-perspective&type=Code

~And~

for offscreen-nav adding perspective to html tag doesn't add perspective. should it add to body instead? https://github.com/h5bp/Effeckt.css/blob/be866c1c2ed9909c35be13542b73a6c9ce0fc742/js/modules/off-screen-nav.js#L56

here's a PR for that #275

wellingguzman commented 10 years ago

Fixed!