search

h5bp / Effeckt.css

This repo is archived. Thanks!
http://h5bp.github.io/Effeckt.css
MIT License
10.88k stars 1.4k forks source link

Can we use bower instead of having jQuery checked in to this repo? #309

Closed ShashankaNataraj closed 9 years ago

ShashankaNataraj commented 9 years ago

I find jQuery 2.1.1 checked in under the libs folder. Not necessary?

arthurvr commented 9 years ago

Yes we can! :+1: Just make sure we don't break the sourcemaps and the grunt deploy stays running fine.

ShashankaNataraj commented 9 years ago

I will take this one step at a time. Let me add a bower file first and we will take it from there.

ShashankaNataraj commented 9 years ago

My pull request has been submitted for this enhancement, I have tested the grunt:demo task on my local system as I do not have permissions to grunt deploy, and see that everything works as it should. Please have a look and let me know if I missed anything.

Also, the one thing remaining for this task to actually be complete is to add an entry in the wiki noting the bower change. Will do that once this pull request is completed :)

ShashankaNataraj commented 9 years ago

@arthurvr , Any suggestions on this pull request?

arthurvr commented 9 years ago

Closing as the pull request landed. Thanks for the hard work, @ShashankaNataraj.