search

h5bp / Effeckt.css

This repo is archived. Thanks!
http://h5bp.github.io/Effeckt.css
MIT License
10.88k stars 1.4k forks source link

Remove Modernizr references #315

Closed ShashankaNataraj closed 5 years ago

ShashankaNataraj commented 9 years ago

In this ticket we discussed that we wanted to remove jQuery from the core altogether.

Why then, do we have references to Modernizr in code? If jQuery is heavy for a library of this purpose, isn't Modernizr heavy too?

arthurvr commented 9 years ago

I think it's worth mentioning that the code you linked up doesn't really require modernizr. If it's not in the global scope, it will just use defaults.

Why then, do we have references to Modernizr in code? If jQuery is heavy for a library of this purpose, isn't Modernizr heavy too?

That's not the question we should be asking. Where are we using it for and is that easy to replace with an alternative approach?

arthurvr commented 9 years ago

Where are we using it for and is that easy to replace with an alternative approach?

What does the rest think?

AaronLayton commented 9 years ago

I would remove modernizr - for the same reasons as jQuery.

Lets see where we are using it already and take it from there

wellingguzman commented 9 years ago

We only used Modernzr to detect wether or not is a touch device and to get the prefixed transition property and jQuery is mostly as element selector and events.

I vote for removing it.

ShashankaNataraj commented 9 years ago

Alright, Im putting dibs on doing this task too :) I will be taking this one up as well, as soon as I get the JSCRC file done on the other issue.

So whats the final word: Remove Modernizr or keep it? general consensus seems to be to remove, Ill wait for a bit in case anyone has any objections to this. Then Ill start off on this.

githubgmq commented 6 years ago

@ShashankaNataraj Is there a schedule to remove Modernizr and jquery?

ShashankaNataraj commented 6 years ago

@githubgmq No.