search

h5bp / ant-build-script

Ant build script intended for use with HTML5 Boilerplate. You may find something useful here, but this project is archived.
MIT License
986 stars 203 forks source link

css-references not updating in html-file #175

Open woeps opened 10 years ago

woeps commented 10 years ago

I just cloned bp5 and the buildscript in a clean directory and everything works fine for the first building-process. After that, the html file won't get updated with the new hashname for the css-file on ant build. - Though changes in the original html-file get respected and the css-file gets copied to the publish-folder with a new hashname. Removing the intermediate-dir makes it work again. Is there a way to just 'update' (change) the existing files in the publish-folder after another build-execution? (Like I understand it's supposed to be.) I'm trying to get this to work for a couple of hours now, but I couldn't find any really helpfull infos. - In the end I wanna set this up together with sass, but that's not the problem.

Did I miss something? Any advice on this?

roblarsen commented 10 years ago

I'm a little confused as to what's happening.

The publish folder will be updated if there's a change to your files. If there's not a change to your files there won't be a change.

Are you seeing any errors in the console?

woeps commented 10 years ago

Sorry, if I was unclear.

I couldn find any errors in the console. (I also tried ant build -debug > log.txt. https://gist.github.com/woeps/97980c3afb631f160acc) Of cause I changed the file's content:

roblarsen commented 10 years ago

What does your HTML file look like before and after the build process?

woeps commented 10 years ago

I haven't really changed the html: https://gist.github.com/woeps/1905f2055b71e031f598 If I add some markup it ends up in the publish-folder like it's supposed to be. I'm afraid the same thing isn't working for the css-reference in the html-file.

Btw: Thanks for your really fast reply!

roblarsen commented 10 years ago

That looks right. I'm not sure what the problem is. On May 3, 2014 6:49 PM, "woeps" notifications@github.com wrote:

I haven't really changed the html: https://gist.github.com/woeps/1905f2055b71e031f598

— Reply to this email directly or view it on GitHubhttps://github.com/h5bp/ant-build-script/issues/175#issuecomment-42118559 .

woeps commented 10 years ago

I'm afraid me neither. I'm trying to get this to work for many hours now, but without any success. That's why I decided to post this issue here. I haven't started messing with the build.xml file yet, cause I wanted it to be compatible to future updates. - I'll look into that..

Atm it seems the only way to get a valid build (for a changed css-file) is by removing the intermediate-folder. Which is kind of okay, but still a bummer in matter of automation.

I'd need to take a closer look at ant to understand what's really going on in this folder. (This is my first use of ant.)

roblarsen commented 10 years ago

I don't understand what's wrong. As in I don't understand what us wrong. Is the css file a 404? You shouldn't have to touch the intermediate folder. On May 3, 2014 7:01 PM, "woeps" notifications@github.com wrote:

I'm afraid me neither. I'm trying to get this to work for many hours now, but without any success. That's why I decided to post this issue here. I haven't started messing with the build.xml file yet, cause I wanted it to be compatible to future updates. - I'll look into that..

Atm it seems the only way to get a valid build (for a changed css-file) is by removing the intermediate-folder. Which is kind of okay, but still a bummer in matter of automation.

I'd need to take a closer look at ant to understand what's really going on in this folder. (This is my first use of ant.)

— Reply to this email directly or view it on GitHubhttps://github.com/h5bp/ant-build-script/issues/175#issuecomment-42118759 .

woeps commented 10 years ago

For test purposes I used the main.css which got shipped with bp5. I only added a (background-)color-atribute to the body declaration (right after the comments which line out, to put additional data afterwards). It appears to be right when checking the original index.html in the browser. But like I said: after the build the updated css gets copied to the publish-folder with a new hashname but the index.html doesn't get updated with the new hashname.

roblarsen commented 10 years ago

What you're describing is confusing. Feel free to send me your whole working directory. Otherwise I have no clue what's going on. On May 3, 2014 7:17 PM, "woeps" notifications@github.com wrote:

For test purposes I used the main.css which got shipped with bp5. I only added a (background-)color-atribute to the body (right after the comments which line out, to put additional data afterwards). It appears to be right when checking the original index.html in the browser. But like I said: after the build the updated css gets copied to the publish-folder with a new hashname but the index.html doesn't get updated with the new hashname.

— Reply to this email directly or view it on GitHubhttps://github.com/h5bp/ant-build-script/issues/175#issuecomment-42119023 .

woeps commented 10 years ago

I pushed my entire working directory here: https://github.com/woeps/mybp5.git

roblarsen commented 10 years ago

Ack, sorry I missed that you had updated this. I can take a look if it's still a problem.

woeps commented 10 years ago

I'd be glad if you had any suggestions. - Still wasn't able to find the cause of this problem.

janusch commented 10 years ago

+1 i am sitting with the same problem. Custom css and js files (mani.css, helper.js, main.js) are minified and concatenated but not referenced in the index.html of the publish folder. I use the 1.1.0 branch of Ant.

I hope we can shed some light on this, i have very little to no experience with Ant.

For now i will just reference the names of the minified files to index myself, and remove the original file names.

roblarsen commented 10 years ago

I'll take a look at this this week. I've had a plan to release 1.1.0 soon and this is one of the things I needed to clear up.

janusch commented 10 years ago

Wonderful, thanks for the super fast feedback!

roblarsen commented 10 years ago

Thank me when I've figured it out :)

The good news is, the "release 1.1.0" item has made it onto my daily to-dos, so it's on the radar at least. This just made no sense to me when I looked at it originally. This is something that worked before so it's a regression somewhere which is always fun to hunt down.

roblarsen commented 10 years ago

Please take a look at the latest in the 1.1.0 branch.