h5bp / html5-boilerplate

A professional front-end template for building fast, robust, and adaptable web apps or sites.
https://html5boilerplate.com/
MIT License
56.27k stars 12.2k forks source link

Form element line-spacing #316

Closed robflaherty closed 13 years ago

robflaherty commented 13 years ago

A minor CSS detail: styles.css, line 67.

Using the font property shorthand without setting an explicit line-height sets line-height to 'normal', which is not equal to the line-height set for the body. Any reason it shouldn't be this instead: select, input, textarea, button { font:99%/1.231 sans-serif; } ?

nimbupani commented 13 years ago

The line height if specified so will be a multiplier of the font size. So 1.231 will not exactly match the body line height. I do not think it is essential and becomes relevant only whe u do vertical rhythm in which case you would have to set it anyway.