Removed twitter logo

[Gowrish7]

Types of changes

fixes #365

• [ ] Bug fix (non-breaking change which fixes an issue) Removed the twitter logo in the footer Thanks!

[Gowrish7]

• changes need to be made in the src/ directory and make a build to update docs/index.html
• Please remove twitter.svg image
• Remove the twitter card meta tags (not just comment them out)

Can you help me with first comment i am new to open source and can you add hacktober label to if its possible now .

[coliff]

Hi. The details to make the build are in the README.

[Gowrish7]

Hi. The details to make the build are in the README.

Hey coliff i have made npm run serve and this is the screen shot

[Gowrish7]

@coliff please check whether the changes done are proper and please do specify if anything went wrong

[coliff]

Changes must be made in the src/ directory. Your PR doesn't include changes to the index file in the src directory. Please update and squash your commits. P.S. sorry, we are not participating in Hacktoberfest.

[pragyamishra56]

[pragyamishra56]

hey why have you done this I've been working on this issue

[Gowrish7]

hey why have you done this I've been working on this issue

Hey @pragyamishra56 its not yet merged you can still submit your PR . I am just learning how to contribute. Thanks

[coliff]

I appreciate the enthusiasm for contributing from you both. :-)

[pragyamishra56]

Gowrish7

How is it possible you already created a PR

[pragyamishra56]

I appreciate the enthusiasm for contributing from you both. :-)

@coliff Could you kindly provide me guidance on How I request to pull the request so that I resolve it?

[Gowrish7]

I appreciate the enthusiasm for contributing from you both. :-)

@coliff Could you kindly provide me guidance on How I request to pull the request so that I resolve it?

@pragyamishra56 i guess you can make a seperate PR or should i close the PR ?

[pragyamishra56]

I appreciate the enthusiasm for contributing from you both. :-)

@coliff Could you kindly provide me guidance on How I request to pull the request so that I resolve it?

@pragyamishra56 i guess you can make a seperate PR or should i close the PR ?

No need to close the PR. Good luck with your next contribution. Maybe that's why, so keep growing and contributing to open source!

[coliff]

Please- let's just get this finished and merged. Please remove the twitter.svg and rebuild. Then squash the commits. thanks.

[pragyamishra56]

Please- let's just get this finished and merged. Please remove the twitter.svg and rebuild. Then squash the commits. thanks.

@coliff me or @Gowrish7

[coliff]

Please- let's just get this finished and merged. Please remove the twitter.svg and rebuild. Then squash the commits. thanks.

@coliff me or @Gowrish7

I really don't mind. Whoever can do it first.

[pragyamishra56]

can I do this? but how if he deletes his pr i can pull the request

[coliff]

can i do this ?

sure, if you want to make a new PR.

[roblarsen]

Hi @pragyamishra56 use this as an opportunity to learn about how open source works. There are plenty

can I do this? but how if he deletes his pr i can pull the request

Just create a new PR. This is a GREAT way to learn about how GitHub and open source works. Consider that part homework to earn your Hacktoberfest t-shirt or whatever you're working towards.

[pragyamishra56]

I appreciate the enthusiasm for contributing from you both. :-)

@coliff Could you kindly provide me guidance on How I request to pull the request so that I resolve it?

@pragyamishra56 I guess you can make a separate PR or should I close the PR?

If you don't mind can you close your PR so that I can create pull request