search

h5bp / mothereffinganimatedgif

Make your animated gifs in the browser! Oh yeah!
https://mothereffinganimatedgif.com/
MIT License
380 stars 109 forks source link

Click should trigger an alternate file upload strategy #59

Open AdamHolwerda opened 10 years ago

AdamHolwerda commented 10 years ago

Drag and drop is great and all, but is it really easier / better? I have to resize all my windows and drag stuff around to even get to the point where I can drag more stuff into the window, and all I want to do is make a gif out of some files. I know the original intent was to mimic dropmocks, which I think it does a good job of, but it's clunky for "file structure first" folks

Intended behavior: if the page is empty and has no gif on it already, anything you click that isn't an obvious link fires a multiple file upload prompt. It would also be cool if it knew which probable order the image files should go in

bgrins commented 10 years ago

I could see adding an input[type=file] (maybe below the 'Drag and Drop images here' box). I don't like auto opening a file picker on any click that isn't obviously a file prompt though.

The FileReaderJS object has a setupInput(node) function that will behave exactly like the drop zone does (https://github.com/h5bp/mothereffinganimatedgif/blob/master/assets/js/libraries/filereader.js#L96), so it shouldn't be too hard to add. If you want to put together a PR for it I can review.

AdamHolwerda commented 10 years ago

What about only opening it when you click inside the Drag and Drop box? And just change the text to "Drag and Drop images here or click to upload"?

I can put together a PR but if someone else wanted to I'm sure they'd beat me to it (this is a lazy web request after all).

Walkman100 commented 10 years ago

What about only opening it when you click inside the Drag and Drop box? And just change the text to "Drag and Drop images here or click to upload"?

:+1: