search

h5o / h5o-js

HTML5 outliner (JavaScript)
MIT License
115 stars 15 forks source link

Added support for alternative texts from img and input type=image #34

Open King2500 opened 8 years ago

King2500 commented 8 years ago

Solves #5

Supports texts from img and input[type=image] alt-attributes.

Included a test case. All tests ran locally without errors.

dominykas commented 8 years ago

Thanks, this is awesome!

I'll go try to revive my work on upgrading to latest nodes, which I forgot all about :)

dominykas commented 8 years ago

If you update with master, the modern nodes will be used on Travis. Might still get a failure on saucelabs, but we can try to deal with it if it does happen.

King2500 commented 8 years ago

Done so far.

King2500 commented 8 years ago

ping @dominykas

Any time for review?

dominykas commented 8 years ago

Sorry, important deadlineand holidays got in the way. Will get back to normal life next week.

King2500 commented 8 years ago

@dominykas How you're doing? Just a reminder ;-)

King2500 commented 7 years ago

@dominykas Do you have any time for reviewing this? It's been almost a year since my pull-request. Thanks!

King2500 commented 7 years ago

Is this project still maintained?

Anything I can help to get this released...?

King2500 commented 5 years ago

@dominykas Any chance for release of this fix? Or do you see any issue with this?