Worker thread implementation essentially halves the setup time for h5p libraries that have many dependencies like h5p-course-presentation and h5p-column.
To-do:
1 - When using the H5P_SSH_CLONE=1 env var and an ssh key with a password added to the ssh-agent, since the cloning now happens in a separate thread, the ssh-agent context is lost and the cloning is done via https instead of ssh. So you cannot push to origin from the cloned repos. This needs to be fixed.
2 - Handle "folder already exists" cloning error as not an error (the same library might be cloned again by another worker thread running in parallel) and let other errors stop the setup as was the case before.
Worker thread implementation essentially halves the setup time for h5p libraries that have many dependencies like h5p-course-presentation and h5p-column.
To-do: 1 - When using the
H5P_SSH_CLONE=1env var and an ssh key with a password added to the ssh-agent, since the cloning now happens in a separate thread, the ssh-agent context is lost and the cloning is done via https instead of ssh. So you cannot push to origin from the cloned repos. This needs to be fixed. 2 - Handle "folder already exists" cloning error as not an error (the same library might be cloned again by another worker thread running in parallel) and let other errors stop the setup as was the case before.