search

h5p / h5p-cli

Command Line Interface
MIT License
64 stars 33 forks source link

JI-6503 filter non-translatable fields for create-language-file utils… #99

Closed devland closed 4 months ago

devland commented 4 months ago

… command

otacke commented 4 months ago

I think HTML tags only (empty text after stripping HTML) should be handled, too. For instance https://github.com/h5p/h5p-dialogcards/blob/9b9614da66319f24b3fa019b4ff61665796e95b9/semantics.json#L84 which is used for centering the field by default, but doesn't contain translatable text.

Also the ColorSelector allows some other color formats as values, cmp. https://github.com/h5p/h5p-editor-color-selector

devland commented 4 months ago

Thanks, Oliver. We can handle the html tags with some regex but the word based color formats cannot be filtered out nor should they because there might be collisions with actual words that people might use in their own translatable labels. This is not meant to be an exhaustive fix. The current semantics format needs an overhaul for that to be possible. Maybe in h5p 2.0. :)