search

h5p / h5p-course-presentation

MIT License
54 stars 130 forks source link

Hiding summary slide does not work if presentation contains exportable text area #147

Open fkohrt opened 3 years ago

fkohrt commented 3 years ago

If a presentation contains an exportable text area, hiding the summary slide does not work.

Tried with exportable-text-area.zip at einstiegh5p.de.

otacke commented 3 years ago

@fkohrt I have never used exportable text areas and can confirm the behavior - but since the button for exporting the text seems to be on the summary slide, what is it that you are feeling is wrong with the behavior?

fkohrt commented 3 years ago
  1. If a user chooses to hide the summary slide, the checkboxes that control the visibility of the buttons Show solutions and Retry become hidden as well -- despite the buttons still being displayed.
  2. The behaviour contradicts what the option to hide the summary slide promises: There is no effect.

I can think of two solutions:

  1. Don't allow to hide the summary slide if presentation contains an exportable text area.
  2. Make visibility of Export text button configurable as well and actually hide the summary slide if the user chooses to.
otacke commented 3 years ago

@fkohrt Much clearer issue already, thanks!

I am not aware how often the exportable text areas are used actually, so I am not sure whether adding complexity to resolve the current behavior that may be an edge case would really be beneficial.

fkohrt commented 3 years ago

suggestion 2) How would you then suggest to export the text of the exportable text areas?

I am new to H5P and couldn't verify so far but I imagined that the text is stored alongside other "results" (such as scores) on the server. If that's not possible then the exportable text area is of course useless without that button. Suggestion 1 would still make sense to me in that case, but of course I imagine there are issues more worthy of dev time.

otacke commented 3 years ago

@fkohrt Not all platforms that H5P runs on have some form of gradebook (like moodle), so I don't think it's optional. And yes, suggestion 1 would probably be possible although it may require some uncommon tinkering with the editor. It's not up to me to decide anyway ;-)

Please continue to share your ideas! If I may suggest to use the forum at https://h5p.org/forum however? I think it's better suited, because most people (well, the total number is still small) discuss feature suggestions there.

fkohrt commented 3 years ago

Please continue to share your ideas! If I may suggest to use the forum at https://h5p.org/forum however? I think it's better suited, because most people (well, the total number is still small) discuss feature suggestions there.

I will, thank you! Maybe expanding the Getting Involved page on h5p.org to a full CONTRIBUTING.md might help newcomers to understand how the H5P community works :)

otacke commented 3 years ago

@fkohrt There's definitely room for improvement in that regard, yes.

fkohrt commented 3 years ago

And I just realized that the Contributing page comes very close to what I meant, didn't notice it before.

otacke commented 3 years ago

@fkohrt Being German, you'll find more "beyond using" information at https://www.oercamp.de/webinare/h5pmaig/ and, for coding in particular, at https://www.youtube.com/playlist?list=PL4lOawnmqTnHuQIBYz7K7LkdTybL3Ui7T

fkohrt commented 3 years ago

Cool, thanks!

Urpokarhu1 commented 4 months ago

Hello,

There is a bug with exportable text area -element in course presentation. When you have a blank course presentation > you add exportable text area > save and display > you navigate to the last page it now contains three buttons

and there should be only one button "export text"

h5p1 h5p2 h5p3

Urpokarhu1 commented 4 months ago

Nevermind I just noticed "problem 1) If you don't want these buttons, you can deactivate them before checking the button to hide the summary slide."

https://github.com/h5p/h5p-course-presentation/issues/147#issuecomment-752759838