search

h5p / h5p-interactive-video

MIT License
236 stars 207 forks source link

Interactive Video - French translation issue on Moodle 3.6 #128

Closed lapie002 closed 5 years ago

lapie002 commented 5 years ago

Hi,

The modal's content of the Interative Video activity has some weird translation issue in French (on a Moodle installed H5P plugin) :

Step to reproduce issue :

And then I notice two translation issues :

Compared to the equivalent English version : modal-en-next

Compared to the equivalent English version : modal-en-done

Does anyone have the same issue ?

I am ussing Mooodle 3.6 with boost template, any help would be appreciated.

Here is also a capture of the ajax call that fails to retreive proper data strings in french.

network-ajax-call

Bruno

lapie002 commented 5 years ago

@thomasmars
I am using the 1.17.2 release of H5P (Build: 2019031301), on a Moodle 3.6 with the core template Boost. I confirm there are no css errors, only DOM elements issues.

lapie002 commented 5 years ago

I confirm that even after upgrading to version 1.19.1 of H5P on the STABLE branch, the issue still persists.

thomasmars commented 5 years ago

Please try to update the content types to their latest versions:

This can be done by grabbing the latest content type version through the content type hub (https://h5p.org/update-all-content-types) and then updating the content through the library adminsitration page (https://h5p.org/library-administration)

lapie002 commented 5 years ago

@thomasmars Hi Thomas,

Thanks for taking the time to reply.

I followed your instructions but it seems that (at least on Moodle), I can't get a higher version than 1.19.1 of H5P plugin (it seems to be alright, since the version of H5P available for Moodle is indeed 1.19.1 (https://moodle.org/plugins/mod_hvp) ).

h5p-version

I am litteraly unable grab the latest version of the Interactive Video Libraries for :

mod-hvp-library_list ).

The library seems to be up to date : (no upgrade required when Interactive video is selected).

no-upgrade-available

I tried to solve the porblem momentarily, by including the strings I needed into /mod/hvp/editor/language/fr.js but that didn't do the trick.

Is there a way to manulally import h5p libraries (Interactive Video, Interactive Video Editor and others) on Moodle LMS ? or What would be the steps to follow in order to track your repository within Moodle localy since I am guessing that all those libraries aren't installed locally once download from H5P GUI (https://github.com/h5p/h5p-editor-interactive-video) ?

Those are ideas to solve the Fr translation issue as a whole for Interactive Video.

thomasmars commented 5 years ago

Please follow the "Update the Content Type Cache" section at our getting started guide for the content type hub, then try to update your Interactive Video, this should get the latest Interactive Video version for you. You may also update manually by downloading the new example content from https://h5p.org/interactive-video and uploading this content to your site if you have the appropriate privileges to install new content types on your site.

lapie002 commented 5 years ago

@thomasmars Hi Thomas,

Again thanks a lot for your pressious time, I am close so close to tackle this issue

I followed the "Update the Content Type Cache", and also made sure that the hub had access to the inetrnet :

update-cache

open-hub

Then I followed you instruction to uplaod the interactive-video-2-618.h5p, by downloading the example content from https://h5p.org/interactive-video

upload-interactive-video

upload-message-error

From the error message, it is pretty clear that it s a version problem. Moodle runs a 1.19.1 version of H5P, while I need at least the latest version 1.23.X.

I am using h5p-moodle-plugin from your github repository (https://github.com/h5p/h5p-moodle-plugin), both master ans stable branches are pointing to the 1.19.1 release.

h5p-release-version

moodle-version

Is there a way, on my side to actaully upgrade the h5p-moodle-plugin to the 1.23.X release ?

Again, thanks for your help.

Bruno

ps: I might think, my issue might interest also other H5P Moodle users, since it affects upgrading version of H5P on the Moodle platform. Let me know.

thomasmars commented 5 years ago

Check the h5p.classes.php file in your H5P plugin installation, what $coreApi version does it say ? It should look like this: https://github.com/h5p/h5p-php-library/blob/7bc8666f309220a0eb93bca49aaa741bb013b26a/h5p.classes.php#L1999-L2002. How did you install the h5p-moodle-plugin ? If you installed it through git, you must make sure that you've updated the submodules, as explained here: https://github.com/h5p/h5p-moodle-plugin#usage

lapie002 commented 5 years ago

Problem sloved 👍

That was a problem with the submodules in https://github.com/h5p/h5p-moodle-plugin not pointing to the latest update on my gitlab repositories.

Once I update the upstream with origin on "master" even if stable is recommended (with you tag on 1.19.1 for Moodle). I was able to solve all the interactive video file uplaod and I confirm String in the popup appeared normally.

Thanks again for your help, it was worth it, at least to understand how the submodules work for future update of H5P.

french-popup-suivant french-popup-valider