search

h5p / h5p-interactive-video

MIT License
235 stars 207 forks source link

Ampersand in the URL break link when using with image #313

Open sokunthearithmakara opened 10 months ago

sokunthearithmakara commented 10 months ago

Steps to replicate:

  1. Add an image to the video
  2. Link the image to an external URL which contains & in the URL address
  3. Publish the interactive video
  4. Click the image
otacke commented 10 months ago

There's a pull request that would fix this issue at https://github.com/h5p/h5p-link/pull/19

sokunthearithmakara commented 10 months ago

Oh wow. That was submitted three years ago and still has not been merged. Anyway, I was wondering why this issue only happens with the image while Navigation Hotspot and URL elements are working fine.

otacke commented 10 months ago

I created a ticket at https://h5ptechnology.atlassian.net/browse/HFP-3848 to draw the product owner's attention to this.

It's only happening here, because the "Navigation Hotspot" subcontent type is using a different approach for the URL generation than the plain "Go To" mechanism built into Interactive Video.