Deprecated curly braces for php7.4

h5p / h5p-php-library

GNU General Public License v3.0

124 stars 128 forks source link

Deprecated curly braces for php7.4 #84

Open michealmouner opened 4 years ago

michealmouner commented 4 years ago

PHP Deprecated: Array and string offset access syntax with curly braces is deprecated in /h5p-app/vendor/h5p/h5p-core/h5p.classes.php on line 2747

seems fixed on master but it needs to be tagged

DanielKulbe commented 4 years ago

Yes, a new tag would be nice.

heddn commented 4 years ago

+1 on a new release.

marclaporte commented 3 years ago

For the record: https://github.com/h5p/h5p-php-library/commit/f6f6d0fb569ebd8adb75eae4cb5de7d464ba8d12

esseremmerik commented 3 years ago

We need a new release with this fix

SebastiaanKloos commented 3 years ago

Can somebody please create the new tag?

TamasSzigeti commented 3 years ago

bump

jonnybradley commented 3 years ago

I'm trying to get h5p to run on php8 so this curly braces issue fix was needed as that's now a fatal error, but now i'm getting over a dozen warnings about Required parameter $varname follows optional parameter - is anyone working on this, and/or should i create a new separate issue about this and php8? TIA