search

h5p / h5p-question-set

6 stars 83 forks source link

Finish Button Text missing #103

Closed pixelhexe closed 2 years ago

pixelhexe commented 2 years ago

After updating (from v 1.17.2 to 1.20.2) there is no finish button text at the end of all questions - just the fontAwesome icon.

If I change the questionset.js as it was before (in the old version), it is ok again.

Please check

finishButtonText: params.endGame.finishButtonText,

vs.

finishButtonText: self.isSubmitting ? params.endGame.submitButtonText : params.endGame.finishButtonText,

as well as

const finishButtonText = (self.isSubmitting) ? params.texts.submitButton : params.endGame.finishButton question.addButton('finish', finishButtonText,

vs.

question.addButton("finish", params.texts.finishButton,

pixelhexe commented 2 years ago

Thanks for fixing this - successfully tested in version 1.20.5! :)