search

h5p / h5p-single-choice-set

MIT License
2 stars 63 forks source link

Single choice set is preventing editor from loading #59

Closed Urpokarhu1 closed 3 years ago

Urpokarhu1 commented 3 years ago

Hello,

Single choice set -question in course presentation is preventing editor from loading in Moodle, also you cannot access pages that has single choice question added. Tested with Moodle 3.5, mod_hvp 1.21.0 & H5P Editor Single Choice Set Textual Editor (1.0.7) & Single Choice Set (1.11.11)

Console is giving error

single-choice-set.js?ver=1.11.11:477 Uncaught TypeError: Cannot read property 'a11yRetry' of undefined
    at SingleChoiceSet.H5P.SingleChoiceSet.SingleChoiceSet.addButtons (single-choice-set.js?ver=1.11.11:477)
    at SingleChoiceSet.H5P.SingleChoiceSet.SingleChoiceSet.registerDomElements (single-choice-set.js?ver=1.11.11:452)
    at SingleChoiceSet.Question.self.attach (question.js?ver=1.4.7:1583)
    at S.attachElement (h5p-course-presentation.js?ver=1.22.2:1)
    at i.t.appendElements (h5p-course-presentation.js?ver=1.22.2:1)
    at S.createSlides (h5p-course-presentation.js?ver=1.22.2:1)
    at S.attach (h5p-course-presentation.js?ver=1.22.2:1)
    at H5PEditor.CoursePresentation.appendTo (cp-editor.js?ver=1.22.1:250)
    at Object.ns.processSemanticsChunk (h5peditor.js?ver=2020080400:475)
    at ns.Form.processSemantics (h5peditor-form.js?ver=2020080400:445)

image

Urpokarhu1 commented 3 years ago

@fnoks

Urpokarhu1 commented 3 years ago

Might be related to https://github.com/h5p/h5p-course-presentation/issues/138

Urpokarhu1 commented 3 years ago

@thomasmars

thomasmars commented 3 years ago

Thank you for reporting this, I've made a fix at https://github.com/h5p/h5p-single-choice-set/commit/eb30f96346c65ceb473bf6ef4e7ad21a3a68da8b. @fnoks will release a new version.

fnoks commented 3 years ago

@Urpokarhu1 : A fix is now released (version 1.11.12). It might take an hour before the cache is invalidated.

Urpokarhu1 commented 3 years ago

Great thanks :)

Urpokarhu1 commented 3 years ago

Updated cache and found the fix, it now works.