H5P-3773 Fix potential memory issue

h5p / h5p-wordpress-plugin

Adds support for H5P Content in WordPress.

https://wordpress.org/plugins/h5p/

70 stars 75 forks source link

Closed otacke closed 9 months ago

otacke commented 1 year ago

When merged in, will

prevent fetching data from all WordPress users if get_users is passed an empty array which could result in memory running short and
limit the amount of data fetched otherwise (as actually none is needed anyway), also reducing memory consumption
ensure that esc_html always has something to work on if for whatever reason no user name can be associated with an entry.

ir4klis commented 1 year ago

@otacke I think that append_user_name() in h5p\admin\class-h5p-plugin-admin.php should also have the fix added as it is the same case.

otacke commented 1 year ago

@ir4klis Would have been cool if you had mentioned that in your first comment. I merely responded to what was reported here.

ir4klis commented 1 year ago

@ir4klis Would have been cool if you had mentioned that in your first comment. I merely responded to what was reported here.

Yeah, sorry, I forgot to mention the related files there. I edited my comment and added the related files.

otacke commented 1 year ago

@otacke No biggie, but I spend my free time here, so if I can finish something in one go without having to return, that's highly appreciated.