H5P Tables Not Deleted When Blog Is Deleted

h5p / h5p-wordpress-plugin

Adds support for H5P Content in WordPress.

https://wordpress.org/plugins/h5p/

71 stars 74 forks source link

H5P Tables Not Deleted When Blog Is Deleted #78

Closed dac514 closed 5 years ago

dac514 commented 6 years ago

WordPress Multisite.

Create a few blogs with the H5P plugin enabled on a per blog basis.
- Example If you have 2 blogs, then 1 of them should not have the plugin activated. (Network activated = false)
Navigate to YOURSITE/wp-admin/network/sites.php
Select a blog where H5P is enabled
Bulk Actions > Delete > Apply > Confirm

Expected: H5P tables are deleted at the same time as the core WordPress tables. Actual: H5P Tables, and data, not deleted. Unwanted leftovers in the DB.

tables-not-deleted

icc commented 6 years ago

That is correct, I don't believe delete_blog really got implemented, it must have been forgotten.

I think it needs to do the same as _h5p_uninstall() in uninstall.php

icc commented 5 years ago

I've added support for _deleteblog which appears to work as intended in my testing environments.

Please reopen if you see any issues with it.