search

h5p / moodle-mod_hvp

H5P Plugin for Moodle
GNU General Public License v3.0
131 stars 171 forks source link

Resizing video interaction height and width does not persist #467

Open Junosprite007 opened 2 years ago

Junosprite007 commented 2 years ago

Moodle 4.0.3

H5P Interactive Video > Single Choice Set > Display as: Poster

When transforming the size of the above type of interaction in a video within Moodle LMS, it resets back to the original size after clicking another interaction, then going back to the first interaction you were trying to change. I haven't testest this with other interactions.

See repro in images below.

  1. Select an interaction to resize. Screen Shot 2022-08-29 at 18 01 38

  2. Drag an anchor point to resize the interaction. Screen Shot 2022-08-29 at 18 02 08

  3. Select another interaction. Screen Shot 2022-08-29 at 18 02 32

  4. Go back to the original interaction you were trying to edit, and the resizing has reverted. Screen Shot 2022-08-29 at 18 02 46

This is preventing me from saving any edits to the size of interactions.

EDIT:

After further troubleshooting, this only occurs when the window dimensions are larger than 767px. Changing interaction sizes persists if you shrink the window to active responsiveness at 767px.

Junosprite007 commented 1 year ago

The issue seems to be that H5P's interactive video settings page does not play nicely with the Boost theme's CSS. I have a custom theme that extends Moodle's Boost theme, so to the scss/post.scss, I added the following lines of code for a quick and dirty fix. I have not fully tested it, but I can't see this causing too many issues.

#page-mod-hvp-mod #topofscroll.main-inner {
    max-width: 100%;
}