h5p / moodle-mod_hvp

H5P Plugin for Moodle
GNU General Public License v3.0
131 stars 168 forks source link

De-Installation of HVP incomplete? #520

Open diolwe opened 9 months ago

diolwe commented 9 months ago

I'm on Moodle 4.1.5 (Build: 20230814). mod_hvp had been removed a rather long time ago (as soon as H5P was part of Moodle core). None the less: When I tried to remove old users yesterday I ran into the following:

Fehler beim Lesen der Datenbank

Weitere Informationen über diesen Fehler
Debug-Info:  Table 'mymoodle_moodle.mdl_hvp' doesn't exist
SELECT cm.*, m.name, md.name AS modname
FROM mdl_course_modules cm
JOIN mdl_modules md ON md.id = cm.module
JOIN mdl_hvp m ON m.id = cm.instance

WHERE m.id = ? AND md.name = ?
AND cm.course = ?
[array (
0 => '1117',
1 => 'hvp',
2 => '501',
)]
Error code: dmlreadexception
Stack trace: 

    line 494 of /lib/dml/moodle_database.php: dml_read_exception thrown
    line 293 of /lib/dml/moodle_read_slave_trait.php: call to moodle_database->query_end()
    line 1282 of /lib/dml/mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->query_end()
    line 1679 of /lib/dml/moodle_database.php: call to mysqli_native_moodle_database->get_records_sql()
    line 1317 of /lib/datalib.php: call to moodle_database->get_record_sql()
    line 1186 of /lib/grade/grade_grade.php: call to get_coursemodule_from_instance()
    line 302 of /lib/grade/grade_object.php: call to grade_grade->notify_changed()
    line 1122 of /lib/grade/grade_grade.php: call to grade_object->delete()
    line 1541 of /lib/gradelib.php: call to grade_grade->delete()
    line 4150 of /lib/moodlelib.php: call to grade_user_delete()
    line 32 of /admin/user/user_bulk_delete.php: call to delete_user()

and I wasn't able to remove them. It looked as if all users who had come into contact with hvp were kind of "locked" by hvp-referencens in their profiles.

So I re-installed HVP and ... then was able to remove my old users (though Moodle threw "Die Instanz dieses Moduls gibt es nicht"-errors in the process)!

I deduce that mod_hvp might have a problem with its deinstallation-routine? If I am not completely wrong: how do I "clean" my Moodle from mod_hvp?