h5p / moodle-mod_hvp

H5P Plugin for Moodle
GNU General Public License v3.0
131 stars 168 forks source link

$CFG->mod_hvp_backup_libraries is undocumented #535

Open marxjohnson opened 5 months ago

marxjohnson commented 5 months ago

We have a client who is concerned that courses with instances of mod_hvp are taking a very long time to backup, sometimes resulting in timeouts from the load balancer.

Looking in to this we found this was due to the inclusion of all H5P libraries in the backup, not just those used on the course. As the site is using ObjectFS, this added the latency of downloading several thousand small files from object storage to the backup task.

It appears that the solution to this is to set $CFG->mod_hvp_backup_libraries = 0; in config.php. I was only able to find this by looking at the code, and there is no explanation of the risks or limitations associated with excluding libraries from backups.

Please could you add some documentation to explain this setting, allowing for informed decisions about whether to use it?

nadavkav commented 2 weeks ago

We use this too, and also found it while looking in the code for a solution to the hague backup files and slow backup process. We turn it ON when doing a course backup with H5P activities that we need to transfer to a different Moodle site, otherwise, it will not work.