h5p / moodle-mod_hvp

H5P Plugin for Moodle
GNU General Public License v3.0
131 stars 168 forks source link

Is $CFG->mod_hvp_export check incorrect? #542

Open marxjohnson opened 4 months ago

marxjohnson commented 4 months ago

In framework::instance(), there is a line that does $export = !(isset($CFG->mod_hvp_export) && $CFG->mod_hvp_export === '0');

Since $CFG->mod_hvp_export is not documented anywhere, I was wondering if this is meant to be a check on get_config('mod_hvp', 'export') (mod_hvp/export in settings.php), rather than a separate setting that has to be defined manually in config.php?