h6ah4i / android-verticalseekbar

Vertical SeekBar class which supports Android 4.x - 9.x.
Apache License 2.0
507 stars 96 forks source link

Strange behaviour of padding #3

Closed Burtan closed 8 years ago

Burtan commented 8 years ago

Hi, padding works very strange when used on VerticalSeekBar (not the wrapper). Padding(all) seems to work for left and right but not top and bottom. PaddingLeft/Right seems to work for bottom only. Also padding works differently between API23 and previous APIs, at least inside of CardViews. Best, Burtan

h6ah4i commented 8 years ago

Hi, @Burtan. Thank you for the issue report. I hope I have fixed this issue by this commit.

Could you try the latest develop branch code and check whether it works as expected on your app? Thanks.

repositories {
    maven { url "https://jitpack.io" }
}

dependencies {
 compile 'com.github.h6ah4i:android-verticalseekbar:2c901c59b230d1f94abdbe24165972bf72454b80'
}
Burtan commented 8 years ago

Is the dependencies link correct? I cannot resolve it, although jitpack is added to the repo list.

h6ah4i commented 8 years ago

At least the above gradle settings code works for me.

h6ah4i commented 8 years ago

@Burtan Hi. Any updates on this issue?

Burtan commented 8 years ago

Hi, the gradle compile link still does not work for me. I've tried to download the source code and import it as a module into my project, but the module had missing files and thus didn't work.

h6ah4i commented 8 years ago

@Burtan Hmm... that seems strange. JitPack is working well, and the repository contains full of required files.

Could you upload the error log messages here? I will take a look at it.

h6ah4i commented 8 years ago

@Burtan Hi. Any progress? I am going to merge the develop branch and release it as v0.7.0 on this weekend .

h6ah4i commented 8 years ago

NOTE: Padding android:paddingLeft and android:paddingRight are just ignored for SeekBar on Android 5.0 or later, so VerticalSeekBar also affects the same limitation. The commit 2c901c59b230d1f94abdbe24165972bf72454b80 fixes broken padding handling on API level 10 and improves touch event handling with padding specified VerticalSeekBar.

h6ah4i commented 8 years ago

v0.7.0 is out.

Burtan commented 8 years ago

I was finally able to test it and it works great, thanks!