h6ah4i / android-verticalseekbar

Vertical SeekBar class which supports Android 4.x - 9.x.
Apache License 2.0
506 stars 96 forks source link

Drag handle goes outside layout bounds #5

Closed AOrobator closed 7 years ago

AOrobator commented 7 years ago

When the seekbar is in a LinearLayout with a specified weight, the drag handle is able to be dragged outside of the seekbar's layout bounds. Here is a sample repo that reproduces this issue 100% of the time: https://github.com/AOrobator/VerticalSeekbarBug

h6ah4i commented 7 years ago

@AOrobator Thanks for the issue report. I will take it a look.

h6ah4i commented 7 years ago

@AOrobator Hi. I have fixed the issue in the develop branch code. Could you try this via JitPack? I am going to release it as v0.7.1 after this issue is resolved. Thanks.

repositories {
  maven { url "https://jitpack.io" }
}

dependencies {
  compile 'com.github.h6ah4i:android-verticalseekbar:c783941ef23a84e167ed72497472691730b51144'
}
AOrobator commented 7 years ago

Thanks! The fix works 👌🏾

h6ah4i commented 7 years ago

Thanks! I am going to reopen this and re-close it after v0.7.1 released.