error_reporting -> E_ALL & ~E_NOTICE

h9k / magirc

PHP Frontend for Anope / Denora IRC Statistics

https://h9k.github.io/magirc/

34 stars 14 forks source link

error_reporting -> E_ALL & ~E_NOTICE #112

Closed flotwig closed 9 years ago

flotwig commented 9 years ago

Changing the error_reporting() call in index.php so that Slim is able to display pretty error pages when a page 404's or 403's, instead of the stack traces which were displaying up until now. Now magIRC displays errors as designed.

h9k commented 9 years ago

Actually in the lib/magirc/Magirc.class.php lib the error_reporting gets modified based on configuration, in the initializeConfiguration function. Are you sure your pull request is needed then?

flotwig commented 9 years ago

Even without debug_mode in the config, it defaults to displaying the user-unfriendly errors. That clause doesn't seem to work as intended.

h9k commented 9 years ago

I'm sorry, I cannot reproduce the problem. Can you please check with the current release (1.0.1) or latest git version if the problem still persists for you?