search

h9k / magirc

PHP Frontend for Anope / Denora IRC Statistics
https://h9k.github.io/magirc/
34 stars 14 forks source link

menu update function does not trigger #122

Closed SISheogorath closed 8 years ago

SISheogorath commented 8 years ago

In my instance of magirc the update for channel links seems not triggering: https://github.com/h9k/magirc/blob/master/js/magirc.js#L183-L196

tried to fix it but didn't found the right point :/

currently it always refer to baseurl/# (for all selectable entries)

h9k commented 8 years ago

Please update to the latest version from github and let me know how it goes. If you still have problems, please tell me which web browser you are using.

SISheogorath commented 8 years ago

Nope still doesn't work I use Firefox 44.0b on Windows 10.

url: https://stats.madirc.net/

h9k commented 8 years ago

Dude, you manipulated magirc.js and added altert('called'); which is misspelled. Please revert to the original magirc.js and see if it works then.

SISheogorath commented 8 years ago

yes, but that manipulation was made after testing for debugging (and yes, it's wrong) but the funny point is it doesn't throw an error to console means no call... means it's not trigger which is the bug I reported

h9k commented 8 years ago

hmmm odd, works for me in ff 43, maybe it's a firefox 44 problem

SISheogorath commented 8 years ago

Sorry I just misunderstood the whole system >.> it triggers on click to the button I thougt about it should trigger on open the menu.