search

hBurt / runecrafting-tracker

BSD 2-Clause "Simplified" License
0 stars 3 forks source link

Fix rune tracking + small UI updates #2

Closed MKuijpers closed 3 years ago

MKuijpers commented 3 years ago

Fixes #1

So, I wanted to use this plugin but I saw it was not working. This PR fixes the plugin and cleans a bit of the UI.

The plugin was broken because the inventory was only stored whenever the message You bind the temple's power into runes. was sent in chat. This does work for the Ourania altar, however, this message is not sent for other altars. I altered the code to respond to the runecrafting animation instead of the previously mentioned chat message.

I also made some small changes to the UI to make it a bit more clear and nice to look at (as well as adding the error panel):

No runes crafted:

Error Panel

Updated interface:

Runecrafting Tracker Interface

Old interface:

Display panel

MKuijpers commented 3 years ago

I found another bug, the runeTracker list was being refilled once you go to the login page. I fixed this by only filling the runeTracker list only if the list is empty. A better solution would be to use some sort of map instead of a list, but this works fine for now.

This also explains the reports from https://github.com/hBurt/runecrafting-tracker/issues/1#issuecomment-675635758 and https://github.com/hBurt/runecrafting-tracker/issues/1#issuecomment-685071803 which said that their entries were being added again after logging in and out.

Fixed this bug in https://github.com/hBurt/runecrafting-tracker/pull/2/commits/6b383ce31812272ceb10ec5f1f6f2b2dccfb5d63