hMatoba / Piexif

Exif manipulation with pure python script.
MIT License
367 stars 81 forks source link

fixes error when reading GPSLatitudeRef and GPSLongitudeRef #133

Open atobiese opened 2 years ago

atobiese commented 2 years ago

This fixes a parsing error when loading exif data. The fix retains the GPSLatitudeRef and GPSLongitudeRef data. This is needed for decimal degree calculation. It is curretly lost. Before: image After:

image image

Saijin-Naib commented 1 year ago

Does this still work for current code?

atobiese commented 1 year ago

It is a bug, yes. The references are lost.

Regarding odm: I see that a fix has been implemented in ODM (photo.py) where the references are assumed if they are missing. A warning is then given. So references are assumed when images are resized.

HerrMuellerluedenscheid commented 1 year ago

@atobiese that looks like a reasonable fix. Can you open a MR at https://github.com/JEFuller/Piexif? @JEFuller kindly took the lead to revitalize support for Piexif (which is not supported here anymore apparently) and is already maintainer of the pypi package 👍