hMatoba / Piexif

Exif manipulation with pure python script.
MIT License
367 stars 81 forks source link

Not writing in 1st #53

Closed TiboDevC closed 6 years ago

TiboDevC commented 6 years ago

I think there is a mistake or a wrong behavior when adding information in the "1st" section.

In this example (web site documentation), no information are adding in section "ImageIFD".

Moreover, to be able to add information in this section, we need to also add a "thumbnail": line 55 in _dump.py if (("1st" in exif_dict) and ("thumbnail" in exif_dict) and (exif_dict["thumbnail"] is not None)):

If not thumbnail is adding in exif information, the function piexif.dump(exif_dict) will ignore every thing contain in "1st". I did not read something about this restriction in the documentation.

Is it possible to fix it?

hMatoba commented 6 years ago

1st IFD is thumbnail's information. What do you use 1st IFD for?

TiboDevC commented 6 years ago

Oh, I thought it was also used to save Exif.Image.ImageDescription (0x010e).