Discard other types of segments that are not Exif (like XMP)

hMatoba / Piexif

Exif manipulation with pure python script.

MIT License

367 stars 81 forks source link

Discard other types of segments that are not Exif (like XMP) #74

Closed cfinnberg closed 5 years ago

cfinnberg commented 5 years ago

It seems that APP1 segments can contain other types of content, like XMP (see https://wwwimages2.adobe.com/content/dam/acom/en/devnet/xmp/pdfs/XMP%20SDK%20Release%20cc-2016-08/XMPSpecificationPart3.pdf - page 13)

coveralls commented 5 years ago

Coverage decreased (-0.08%) to 94.952% when pulling 73c49ae7702865920ed7861a3901d35a61dbfe38 on cfinnberg:patch-1 into dc5b3c8a20d6efff99cff8809ef2769b74deed4c on hMatoba:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 94.87% when pulling ec5b74a4e4b3150124228cf342f8c4b86114e46e on cfinnberg:patch-1 into dc5b3c8a20d6efff99cff8809ef2769b74deed4c on hMatoba:master.

hMatoba commented 5 years ago

Thanks! But I think that it should continue loop when "segment_data[0:4] != b'Exif'". Could you change break to continue and make new pull request?

hMatoba commented 5 years ago

I'll make a new release in a few days. Thank you for your contribution.

tvanderweide commented 4 years ago

Is there a way to load XMP data in the current version of piexif?

manuelrames commented 1 month ago

Is there a way to load XMP data in the current version of piexif?

Or a way of embedding XMP info into an image using piexifjs?