haaarshsingh / kmenu

The perfect ⌘K menu
https://kmenu.harshsingh.xyz
MIT License
780 stars 25 forks source link

Dimension has no type exported #103

Open prajnaprabhu3 opened 1 year ago

prajnaprabhu3 commented 1 year ago

Describe the bug dimensions which can be passed as prop to MenuProvider has no type import from kmenu. Its got a type Partial<Dimensions>

Expected behavior dimensions has type Partial<Dimensions>. I don't see this type being exported. I'm not sure if there's any other way to use it, but exporting its type as MenuDimension similar to whats done for config as MenuConfig would be convenient.

import { Config } from './types';
import './styles/index.css';

export { CommandMenu } from './CommandMenu';
export { CommandWrapper } from './CommandWrapper';
export declare type MenuConfig = Partial<Config>;
export declare type MenuDimension = Partial<Dimensions>;

export { Command, MenuProps } from './types';
export { useShortcut } from './hooks/useShortcut';
export { useCommands } from './hooks/useCommands';
export { useKmenu } from './hooks/useKmenu';
export { MenuProvider } from './MenuProvider';

Additional context Let me know if there's any other way this can be done.

haaarshsingh commented 1 year ago

@Prajnaprabhu3 thanks for pointing this out, I'll get on it ASAP.