search

haacked / Encourage

A bit of encouragment added to Visual Studio
75 stars 32 forks source link

Remove javascript signatures from encouragement #17

Closed jaredpar closed 10 years ago

jaredpar commented 10 years ago

The Javascript IDE implementation has a bug where by it will insert its signature help into any ISignatureHelpSession that is started. This includes the session that is started by the Enouragement extension. This causes encouragement tips to be intermixed with javascript signatures

Due to the implementation of the Javascript provider the only suitable short term fix is to a) run after them and b) just remove their signatures from our session.

This fixes #16

As a consequence it also fixes #1 as well.

haacked commented 10 years ago

Do you mean this also fixes #9

jaredpar commented 10 years ago

@Haacked yes, that's what I get for typing up my commit messages without an internet connection

:-1: