search

haacked / feedback

Ask @haacked anything!
7 stars 1 forks source link

Careful now: possible recursion detected #179

Closed bartelink closed 6 years ago

bartelink commented 6 years ago

In https://haacked.com/archive/2018/01/27/analyze-github-issue-comment-sentiment/ you have requested that I:

Install-Package nuget

I'm scared this might cause a DDOS attack.

Maybe using octokit.net might serve to mitigate?

Please refer to this issue for further details.

Also, in same post, should linkify https://github.com/haacked-demos/azure-sentiment-analysis/

haacked commented 6 years ago

Ha! Whoops. Thanks! I fixed it.

bartelink commented 6 years ago

Looks better ;) (But the github link is still text)

And thanks for doing the demo and the post!

haacked commented 6 years ago

Which link? Also, you can click the edit link in my posts if you want to propose a fix and get credit. :) On Tue, Jan 30, 2018 at 12:27 PM Ruben Bartelink notifications@github.com wrote:

Looks better ;) (But the github link is still text)

And thanks for doing the demo and the post!

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Haacked/feedback/issues/179#issuecomment-361723663, or mute the thread https://github.com/notifications/unsubscribe-auth/AABOCcdVyyhTd-fOYY55hZxEaifduG3_ks5tP3stgaJpZM4RvnLr .

bartelink commented 6 years ago

Wait, the edit link is news/not prominent enough for me, will do! No credit needed (I had a quick scan for a blog repo but didnt find one!)

haacked commented 6 years ago

no credit needed

I can't help it. My "contributors" page is built off of GitHub data. So if you submit a PR with a proposed correction and I merge it, you automatically show up on this URL: https://haacked.com/contributors/

bartelink commented 6 years ago

Nice. One tile won't repave my shower mosaic alone but hey...

Re the edit link, I didnt see the haacked.com repo pinned in github.com/haack so gave up.

The edit link at the top of the page does not jump out as a "anyone could click this" to me, even if, now that I know what it is, it seems perfectly reasonable and friendly (in my head as I scanned it I reckon it got lumped, unfairly, in the "artifact of blog engines that expose admin links as part of the text with undue prominence" bucket).

bartelink commented 6 years ago

🤔 Perhaps cloning Edit pencil as a [suggest and edit for this page] long-titled link at the bottom of the page might better align with where/when people will expect to find such a link ?

haacked commented 6 years ago

@bartelink interesting idea. So make it more clear that you can suggest an edit?