search

haacked / seegit

SeeGit - The Git Repository Visualizer
MIT License
508 stars 107 forks source link

Add username who made the commit - Issue #85 #86

Closed ben-m-lucas closed 7 years ago

ben-m-lucas commented 7 years ago

Implementation for adding the username who made the commit

haacked commented 7 years ago

Thanks! I'll try and look at this soon.

haacked commented 7 years ago

One of the goals of SeeGit is to be a teaching tool during a live talk. In that scenario, the speaker is the only one making commits so the name is redundant.

My preference would be to add a setting to show the name and default it to be off. We already have other settings. If you make the setting sticky, it should accomplish what you want here.

ben-m-lucas commented 7 years ago

That makes sense. I added an option in the settings for showing the Commit Author.

I did have one bit of code in the OnToggleSettings method that I'm not thrilled with. When the commit author is displayed, it changes the width of each CommitVertex. When this happens, a call to Relayout needs to be made. Ideally, the fact that the Graph property of the ViewModel changed should be enough information for the control to know that it needs to lay itself out again. I'm not familiar enough with the RepositoryGraphLayout control to do this though.

haacked commented 7 years ago

Maybe the Width property doesn't implement INotifyPropertyChanged properly. In any case, I'm happy with that trade-off. People don't change their settings all the time.

haacked commented 7 years ago