search

haampie / libtree

ldd as a tree
MIT License
2.67k stars 60 forks source link

Match automake variable names #76

Closed ismaell closed 2 years ago

ismaell commented 2 years ago

Also, allow overriding the manual pages directory.

haampie commented 2 years ago

hm, this is a breaking change. Can you initialize prefix with PREFIX? Also whatever is defined in Make.user will be overridden, right?

ismaell commented 2 years ago

Can you initialize prefix with PREFIX?

done.

Also whatever is defined in Make.user will be overridden, right?

yes, if you want contents of Make.user to take precedence, I can just move it after the variables (using ?= instead is a little bit dangerous, IMHO). Then the order would be: arguments, Make.user, Makefile.

ismaell commented 2 years ago

Ping.

iluceno commented 2 years ago

Thanks.

iluceno commented 2 years ago

BTW, this is required by pkgsrc and other buildsystems to install without hacks. See: https://mail-index.netbsd.org/tech-pkg/2022/03/22/msg026097.html. Now it's possible to specify: mandir=${PKGMANDIR} to get manpages correctly installed.

So I'm hoping you make a release including this soon :).

Would you consider a GNU-style configure script to produce Make.user?

haampie commented 2 years ago

It's in 3.0.4 and 3.1.1 :) I was hoping to keep things very simple, so there must be a compelling reason to want a configure script

ismaell commented 2 years ago

It's in 3.0.4 and 3.1.1 :) I was hoping to keep things very simple, so there must be a compelling reason to want a configure script

No, you included PR #75 but not this one.

ismaell commented 2 years ago

Hey! I'm waiting for this to be included in a release, in order to fix the pkgsrc port and a few others.

ismaell commented 4 months ago

Ping. So, the pkgsrc package is still waiting for this to be included in a release...