search

haasad / EcoInventDownLoader

Download, unpack and import ecoinvent into your brightway2 project in one simple step
MIT License
13 stars 6 forks source link

Add compatibility with brightway25 #26

Closed mijafro closed 2 years ago

mijafro commented 2 years ago

With brightway25 we can no longer "from brightway25 import ...", instead import directly from sub-packages.

I replaced "import from brightway2" by imports from "bw2data" and "bw2io" in core.py ; modifications are also applied to files readme.md and conda-recipe/meta.yaml

haasad commented 2 years ago

Hi @mijafro, thank you very much for the contribution. Looks good :+1: I'll merge and make a new release shortly

mijafro commented 2 years ago

Hi @mijafro, thank you very much for the contribution. Looks good 👍 I'll merge and make a new release shortly

You're welcome. It is the first time I make a pull request so maybe it is not perfect. I see a check has failed because of the change I made in meta.yaml, replacing brigthway2 by bw2data and bw2io, maybe this change was not necessary ?

haasad commented 2 years ago

You're welcome. It is the first time I make a pull request so maybe it is not perfect.

Well, in that case I feel honoured that your first PR is to one of my projects :blush:

I see a check has failed because of the change I made in meta.yaml, replacing brigthway2 by bw2data and bw2io, maybe this change was not necessary ?

This is very much necessary, otherwise installing eidl would force you to install brightway2, even if you intended to use brighway25.

The failing check for the PR is a "bug" in the github actions that only happens for PRs from a fork as far as I can tell. Never noticed it before, because usually I'm the only one making PRs to this repo.

The check doesn't fail anymore once the PR is merged: https://github.com/haasad/EcoInventDownLoader/actions/runs/2207965525

Btw I made a new release now https://github.com/haasad/EcoInventDownLoader/releases/tag/1.5.0, you should be able to install a new version with your changes from conda :tada:

mijafro commented 2 years ago

Ok perfect then ! Thank you very much 😊