search

haasad / EcoInventDownLoader

Download, unpack and import ecoinvent into your brightway2 project in one simple step
MIT License
13 stars 6 forks source link

allow specified path to download .7z file to #9

Closed pjamesjoyce closed 5 years ago

pjamesjoyce commented 5 years ago

Add the ability to specify a download_path to get_ecoinvent as an optional kwarg

This could be a first step towards a solution for #6.

I've stopped short of specifying an appdirs directory though, mainly because for my use case I want to store the .7z files in an lcopt system directory so if you change the name of your single project (or delete one of your setup projects), you can use a predownloaded .7z file to import ecoinvent.

haasad commented 5 years ago

Thanks James! I'm not super happy with the **kwargs, because it makes the code harder to understand. But that's entirely my fault. I'm anyway planning to restructure the eidl-code, because atm it can't be used in the AB and I have two parallel codebases that do basically the same. Will let you know if there are any significant changes that affect lcopt.

pjamesjoyce commented 5 years ago

Thanks Adrian!