haasn / libplacebo

Official mirror of libplacebo
http://libplacebo.org/
GNU Lesser General Public License v2.1
524 stars 63 forks source link

s390x test failure with new release #207

Closed bl4ckb0ne closed 9 months ago

bl4ckb0ne commented 9 months ago

Hello there,

I upgraded the libplacebo package in Alpinelinux with the new release. CI is all green except on s390x where one test fails (build log here 1)

 1/14 colorspace.c         OK               0.03s
 2/14 common.c             OK               0.03s
 3/14 lut.c                OK               0.02s
 4/14 cache.c              FAIL             0.04s   exit status 1
>>> MALLOC_PERTURB_=35 /builds/alpine/aports/community/libplacebo/src/libplacebo-v6.338.0/output/src/tests/test.cache.c
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
stdout:
[0.000][i] Initialized libplacebo v6.338.0 (API v338)
[0.000][d] Spent 0.001 ms saving cache
[0.000][d] Saved 2 objects, totalling 7 bytes
stderr:
=== FAILED: memcmp(data, ref, sizeof(ref)) == 0 at ../src/tests/cache.c:90
at position 8: 0x00 != 0x01
72 bytes of 'data' at offset 0:
70 6c 5f 63 61 63 68 65 \x1b[31;1m00\x1b[0m 00 00 \x1b[31;1m01\x1b[0m \x1b[31;1m00\x1b[0m 00 00 \x1b[31;1m02\x1b[0m
\x1b[31;1m00\x1b[0m 00 00 00 00 00 00 \x1b[31;1m03\x1b[0m \x1b[31;1m00\x1b[0m 00 00 00 00 00 00 \x1b[31;1m04\x1b[0m
\x1b[31;1mec\x1b[0m \x1b[31;1m18\x1b[0m \x1b[31;1m88\x1b[0m \x1b[31;1m4e\x1b[0m \x1b[31;1m5e\x1b[0m \x1b[31;1m47\x1b[0m \x1b[31;1m11\x1b[0m \x1b[31;1m17\x1b[0m 78 79 7a 77 \x1b[31;1m00\x1b[0m 00 00 00
00 00 00 \x1b[31;1m01\x1b[0m \x1b[31;1m00\x1b[0m 00 00 00 00 00 00 \x1b[31;1m03\x1b[0m \x1b[31;1m3a\x1b[0m \x1b[31;1m20\x1b[0m \x1b[31;1m4d\x1b[0m \x1b[31;1m40\x1b[0m
\x1b[31;1m8a\x1b[0m \x1b[31;1m2e\x1b[0m \x1b[31;1m2d\x1b[0m \x1b[31;1m77\x1b[0m 61 62 63 00
72 bytes of 'ref' at offset 0:
70 6c 5f 63 61 63 68 65 \x1b[31;1m01\x1b[0m 00 00 \x1b[31;1m00\x1b[0m \x1b[31;1m02\x1b[0m 00 00 \x1b[31;1m00\x1b[0m
\x1b[31;1m03\x1b[0m 00 00 00 00 00 00 \x1b[31;1m00\x1b[0m \x1b[31;1m04\x1b[0m 00 00 00 00 00 00 \x1b[31;1m00\x1b[0m
\x1b[31;1m17\x1b[0m \x1b[31;1m11\x1b[0m \x1b[31;1m47\x1b[0m \x1b[31;1m5e\x1b[0m \x1b[31;1m4e\x1b[0m \x1b[31;1m88\x1b[0m \x1b[31;1m18\x1b[0m \x1b[31;1mec\x1b[0m 78 79 7a 77 \x1b[31;1m01\x1b[0m 00 00 00
00 00 00 \x1b[31;1m00\x1b[0m \x1b[31;1m03\x1b[0m 00 00 00 00 00 00 \x1b[31;1m00\x1b[0m \x1b[31;1m77\x1b[0m \x1b[31;1m2d\x1b[0m \x1b[31;1m2e\x1b[0m \x1b[31;1m8a\x1b[0m
\x1b[31;1m40\x1b[0m \x1b[31;1m4d\x1b[0m \x1b[31;1m20\x1b[0m \x1b[31;1m3a\x1b[0m 61 62 63 00
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
 5/14 dither.c             OK               0.04s
 6/14 filters.c            OK               0.05s
 7/14 options.c            OK               0.04s
 8/14 dummy.c              OK               0.06s
 9/14 string.c             OK               0.04s
10/14 utils.c              OK               0.04s
11/14 opengl_surfaceless.c SKIP             0.03s   exit status 77
12/14 vulkan.c             SKIP             0.03s   exit status 77
13/14 icc.c                OK               0.02s
14/14 tone_mapping.c       OK               0.05s
Summary of Failures:
 4/14 cache.c              FAIL             0.04s   exit status 1
Ok:                 11  
Expected Fail:      0   
Fail:               1   
Unexpected Pass:    0   
Skipped:            2   
Timeout:            0   
Full log written to /builds/alpine/aports/community/libplacebo/src/libplacebo-v6.338.0/output/meson-logs/testlog.txt
kasper93 commented 9 months ago

Should be fixed by https://code.videolan.org/videolan/libplacebo/-/merge_requests/603

not tested tho, so give it a try if you can.

haasn commented 9 months ago

Sorry, what? libplacebo has almost no chance of working on big endian systems.

bl4ckb0ne commented 9 months ago

It was working before, and it seems that @kasper93's patch fixed the issue