haasn / libplacebo

Official mirror of libplacebo
http://libplacebo.org/
GNU Lesser General Public License v2.1
523 stars 63 forks source link

Compilation failure due to OGLCompiler being removed from glslang and shaderc #226

Open rxguy opened 7 months ago

rxguy commented 7 months ago

As described in the title, see:

https://github.com/KhronosGroup/glslang/commit/6be56e45e574b375d759b89dad35f780bbd4792f

and

https://github.com/google/shaderc/commit/40bced4e1e205ecf44630d2dfa357655b6dabd04

I can build successfully with this small patch.


--- libplacebo/src/glsl/meson.build 2023-12-02 20:48:51.445273381 -0400
+++ libplacebo_patch/src/glsl/meson.build   2023-12-05 10:56:49.083295970 -0400
@@ -44,7 +44,7 @@ elif not glslang_req.disabled()
         # Always required for static linking
         cxx.find_library('MachineIndependent', required: true, static: true),
         cxx.find_library('OSDependent',        required: true, static: true),
-        cxx.find_library('OGLCompiler',        required: true, static: true),
+#        cxx.find_library('OGLCompiler',        required: true, static: true),
         cxx.find_library('GenericCodeGen',     required: true, static: true),
         # SPIRV-Tools are required only if optimizer is enabled in glslang build
         cxx.find_library('SPIRV-Tools',        required: false, static: true),

libplacebo-OGLCompiler.patch

Thanks, Dale

jfe1205 commented 5 months ago

The issue remains and probably needs to be posted on Videolan to receive any attention.