haasn / libplacebo

Official mirror of libplacebo
http://libplacebo.org/
GNU Lesser General Public License v2.1
547 stars 69 forks source link

Query on: HDR passthrough in ffmpeg's libplacebo's filter #251

Closed Brainiarc7 closed 5 months ago

Brainiarc7 commented 5 months ago

Hello there,

Does ffmpeg's libplacebo filter implementation support HDR passthrough? Is there a switch needed to enable this, or is this toggled on by default? I see an MR on this topic opened ~2 years ago, with the description:

Technically, this just requires forwarding the colorspace and HDR
metadata information to the libplacebo swapchain.
In practice, this does nothing at all on OpenGL, and for Vulkan it only
works with implementations that provide VK_KHR_swapchain_colorspace and
VK_EXT_hdr_metadata, which in practice means "Windows, Wayland and DRM
only", although we don't support DRM or wayland (yet) so it really just
means "Windows only".

Does the same also apply to the filter?

haasn commented 5 months ago

https://ffmpeg.org/ffmpeg-filters.html#Output-mode

Configure the colorspace that output frames will be delivered in. The default value of auto outputs frames in the same format as the input frames, leading to no change. For any other value, conversion will be performed.

The MR you quoted has nothing to do with the filter, it's talking about output to the display.