search

haassie / rh_recaptcha

TYPO3 extension implementing Google reCAPTCHA
1 stars 9 forks source link

[BUGFIX] Fix TypoScript include #18

Closed rschaufler closed 7 years ago

rschaufler commented 7 years ago

TypoScript can not be included via ext_localconf.php

Using \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addStaticFile in ext_localconf.php has no effect what so ever and makes the extension unusable for me as is.

Tested with TYPO3 CMS 7.6.18

Scunkaneli commented 7 years ago

Doing this does no longer work with CMS 8, as described here.

My pull request #17 , which is already available now for over a month, fixes the same issue, but respects the Migration rules of the Typo3 Core team. I suggest using exactly the request I propsed, as it's also featured by the Typo3 core team:

In ext_tables.php neither writing directly to $GLOBALS['TCA'] and $TCA is allowed, nor writing indirectly via ExtensionManagementUtility methods.

ExtensionManagementUtility::addStaticFile(): A static file is registered in sys_template. Add this to Configuration/TCA/Overrides/sys_template.php

rschaufler commented 7 years ago

Thanks for your feedback @Scunkaneli, i didn't check your pull request when i created mine. Does your pull request also work with TYPO3 CMS 7.6.x?

Scunkaneli commented 7 years ago

In #16 baden32 seems to be able to use it on CMS 7.6.18, if I'm not mistaken. Sadly I can't test it, as my only Typo3 configuration is on 8.7.1, but I can't see any reason why it should not work.

If you want, you could also try it and report back :)

rschaufler commented 7 years ago

I will try and gladly close this PR if it works @Scunkaneli 🤘

Scunkaneli commented 7 years ago

Alright I'm excited to hear back!

rschaufler commented 7 years ago

@Scunkaneli your pull request works just fine in TYPO3 CMS 7.6.x 🥇 will close this one now